fix(web): make wizard duration selection consistent #98

Merged

eleith merged 3 commits from fix/wizard-duration-consistency into main 2026-10-26 23:42:05 +00:00

Conversation 0 Commits 3 Files Changed 14

+253 -369

eleith-gitea-agent Bot commented 2026-10-26 23:17:18 +00:00

Copy link

Copy source

Summary

• Clear unavailable selected days after duration changes; disable Continue and remove stale URL selections while preserving valid choices and empty time-picker recovery.
• Sort duration choices numerically, independently of valid duration links, configured defaults and booked rescheduling lengths.
• Use one compact booking-settings row on day/time/empty states: duration left, timezone right, divider below. Existing dialogs replace the stepper; fixed durations are plain text and final details remain read-only.
• Keep selected instants when timezone changes, and clear calendar-day selections that become unavailable.

Three individually reviewed commits

1. 86dcb56 — unavailable selected-day fix.
2. 5f2e795 — numeric choice ordering, unchanged defaults and permissions.
3. b0ea555 — compact shared duration/timezone settings.

Each includes a web patch changeset. No new dependencies or role-permission changes.

Validation

Each commit received owner code review, independent correctness/readability reviews (clear), and checks before staging. The final design also received owner visual review.

• All web Vitest tests: 1,065 passed after each commit's changes.
• Final affected browser journeys: 13 passed, retries disabled — duration/host booking/rescheduling, guest booking, deep links and timezone-crossing absolute slot links.
• Earlier commits: existing duration browser suite, 7 passed, retries disabled after each change.
• Svelte check: 0 errors / warnings; full web formatting/ESLint, changeset formatting and diff checks passed.
• Isolated browser setup built production code without touching developer config/data/build output.

Testing stays focused: one browser regression plus three fast state cases added for the original defect; ordering and shared settings reuse existing tests rather than adding a browser matrix. These are local validation results, not a claim that remote CI has completed.

## Summary - Clear unavailable selected days after duration changes; disable Continue and remove stale URL selections while preserving valid choices and empty time-picker recovery. - Sort duration choices numerically, independently of valid duration links, configured defaults and booked rescheduling lengths. - Use one compact booking-settings row on day/time/empty states: duration left, timezone right, divider below. Existing dialogs replace the stepper; fixed durations are plain text and final details remain read-only. - Keep selected instants when timezone changes, and clear calendar-day selections that become unavailable. ## Three individually reviewed commits 1. 86dcb56 — unavailable selected-day fix. 2. 5f2e795 — numeric choice ordering, unchanged defaults and permissions. 3. b0ea555 — compact shared duration/timezone settings. Each includes a web patch changeset. No new dependencies or role-permission changes. ## Validation Each commit received owner code review, independent correctness/readability reviews (clear), and checks before staging. The final design also received owner visual review. - All web Vitest tests: **1,065 passed** after each commit's changes. - Final affected browser journeys: **13 passed, retries disabled** — duration/host booking/rescheduling, guest booking, deep links and timezone-crossing absolute slot links. - Earlier commits: existing duration browser suite, **7 passed, retries disabled** after each change. - Svelte check: **0 errors / warnings**; full web formatting/ESLint, changeset formatting and diff checks passed. - Isolated browser setup built production code without touching developer config/data/build output. Testing stays focused: one browser regression plus three fast state cases added for the original defect; ordering and shared settings reuse existing tests rather than adding a browser matrix. These are local validation results, not a claim that remote CI has completed.

eleith-gitea-agent Bot added 1 commit 2026-10-26 23:17:18 +00:00

fix(web): clear unavailable wizard day selections 86dcb56106

eleith added 1 commit 2026-10-26 23:22:32 +00:00

fix(web): order duration choices independently of defaults 5f2e7958a7

eleith added 1 commit 2026-10-26 23:38:44 +00:00

refactor(web): share compact wizard booking settings b0ea5554e2

eleith-gitea-agent Bot marked the pull request as ready for review 2026-10-26 23:39:27 +00:00

eleith merged commit b0ea5554e2 into main 2026-10-26 23:42:05 +00:00

eleith deleted branch fix/wizard-duration-consistency 2026-10-26 23:42:05 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

blocked

Waiting on a prerequisite before work can proceed

bug

Something is not working

enhancement

New feature

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

eleith-gitea-agent Bot eleith (eleith)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: eleith/when#98