Retain session comments with a focused quickfix workflow #3

Merged

eleith merged 9 commits from feat/session-comments-reviewable into main 2026-09-30 17:27:19 +00:00

Conversation 0 Commits 9 Files Changed 28

+2286 -781

eleith commented 2026-09-30 15:21:00 +00:00

Owner

Copy link

Copy source

Supersedes #2. The initial four commits rebuilt its final tree from main in reviewable steps; the follow-up commits address code and test review findings, so this branch now includes fixes beyond #2.

Initial commits:

1. Retain comments through buffer lifecycle and conservative source reattachment.
2. Use quickfix for navigation and comment cards for editing and deletion.
3. Recheck pending quickfix jumps after asynchronous reattachment.
4. Document the session comment workflow.

Focused review follow-ups: URI orphan detection and live-range snapshots; cross-tab quickfix refresh and focus; filtered-list and navigation tests; reopened quickfix window safety and mappings.

Verification: make check passes (207 tests).

Supersedes #2. The initial four commits rebuilt its final tree from main in reviewable steps; the follow-up commits address code and test review findings, so this branch now includes fixes beyond #2. Initial commits: 1. Retain comments through buffer lifecycle and conservative source reattachment. 2. Use quickfix for navigation and comment cards for editing and deletion. 3. Recheck pending quickfix jumps after asynchronous reattachment. 4. Document the session comment workflow. Focused review follow-ups: URI orphan detection and live-range snapshots; cross-tab quickfix refresh and focus; filtered-list and navigation tests; reopened quickfix window safety and mappings. Verification: `make check` passes (207 tests).

eleith added 4 commits 2026-09-30 15:21:01 +00:00

Retain comments through buffer lifecycle and source reattachment e0c5a011ea

Use quickfix for navigation and comment cards for editing d8403eb621

Recheck pending quickfix jumps after async reattachment 061877b05e

Document the session comment workflow d34007bf19

eleith referenced this pull request 2026-09-30 15:21:50 +00:00

Retain scratch comments across buffer lifecycle changes #2

eleith added 5 commits 2026-09-30 16:31:50 +00:00

Treat edited URI anchors as orphans after reattachment 675f6fae54

Refresh the owning quickfix list without stealing tab focus 907f38f550

Cover filter, fallback, and moved-anchor behavior; remove unused updates 563227c79c

Track live URI ranges through provider replacements a42a5f9e18

Recognize reopened manager windows without adopting location lists c1b4eafd55

eleith merged commit c1b4eafd55 into main 2026-09-30 17:27:19 +00:00

eleith deleted branch feat/session-comments-reviewable 2026-09-30 17:27:19 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

enhancement

New feature

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

eleith (eleith)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: eleith/scratch-comments.nvim#3