fix(tool-rendering): honor native output padding #18

Merged

eleith merged 2 commits from fix/tool-rendering-output-padding into main 2026-11-05 20:22:11 +00:00

Conversation 0 Commits 2 Files Changed 8

+269 -21

eleith-gitea-agent Bot commented 2026-11-05 20:16:47 +00:00

Copy link

Copy source

Summary

• Apply public context.outputPad to shared self-shell tool frames via native Text.setPaddingX.
• Match native narrow-terminal padding clamping before measuring/wrapping, retaining the 210-column content cap with margins outside it.
• Invalidate layout when padding changes, including rows whose capped paint width is unchanged; preserve stable redraw caches.
• Reuse the existing clipping-marker fallback when a raw painter (such as bash command chrome) contains wide glyphs in a one-column content area.
• Include patch changesets for tool-rendering, web-fetch, and web-search-codex; document the shared frame contract.

Validation

• Full suite: 76 files / 1,458 tests passed.
• Typecheck, lint, repository formatting, whitespace checks, and all nine extension builds passed.
• Shared tests cover 0/1 margins, painter widths, resize, cache invalidation, Unicode, narrow terminals, and the content cap.
• Real SDK ToolExecutionComponent tests exercise default padding and live 1→0→1 changes across all seven built-ins, including errors.
• Web-fetch, batch, and search tests cover headers, compact/expanded results, search errors, content-width alignment, bounds, and immutable results.
• Validation used installed Pi 1.5; minimum Pi runtime compatibility and live terminal interaction were not exercised.

Reviews

Independent code, readability, and test reviews are clear. Readability suggestions were applied by extracting the SDK padding matrix into a file-local helper and naming configuration decisions before construction. Final checks passed after those changes.

The user-approved simplification of extensions/tool-rendering/README.md is included as a separate docs-only commit; README formatting and staged whitespace checks passed. No extension-specific padding setting, execution change, or unrelated cache cleanup is included.

## Summary - Apply public `context.outputPad` to shared self-shell tool frames via native `Text.setPaddingX`. - Match native narrow-terminal padding clamping before measuring/wrapping, retaining the 210-column content cap with margins outside it. - Invalidate layout when padding changes, including rows whose capped paint width is unchanged; preserve stable redraw caches. - Reuse the existing clipping-marker fallback when a raw painter (such as bash command chrome) contains wide glyphs in a one-column content area. - Include patch changesets for tool-rendering, web-fetch, and web-search-codex; document the shared frame contract. ## Validation - Full suite: 76 files / 1,458 tests passed. - Typecheck, lint, repository formatting, whitespace checks, and all nine extension builds passed. - Shared tests cover 0/1 margins, painter widths, resize, cache invalidation, Unicode, narrow terminals, and the content cap. - Real SDK `ToolExecutionComponent` tests exercise default padding and live 1→0→1 changes across all seven built-ins, including errors. - Web-fetch, batch, and search tests cover headers, compact/expanded results, search errors, content-width alignment, bounds, and immutable results. - Validation used installed Pi 1.5; minimum Pi runtime compatibility and live terminal interaction were not exercised. ## Reviews Independent code, readability, and test reviews are clear. Readability suggestions were applied by extracting the SDK padding matrix into a file-local helper and naming configuration decisions before construction. Final checks passed after those changes. The user-approved simplification of `extensions/tool-rendering/README.md` is included as a separate docs-only commit; README formatting and staged whitespace checks passed. No extension-specific padding setting, execution change, or unrelated cache cleanup is included.

eleith-gitea-agent Bot added 1 commit 2026-11-05 20:16:47 +00:00

fix(tool-rendering): honor native output padding 40de6afac0

eleith added 1 commit 2026-11-05 20:18:34 +00:00

docs(tool-rendering): simplify usage notes c44a952fd1

eleith merged commit c44a952fd1 into main 2026-11-05 20:22:11 +00:00

eleith deleted branch fix/tool-rendering-output-padding 2026-11-05 20:22:11 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

eleith-gitea-agent Bot eleith (eleith)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: eleith/pi-extensions#18