eleith/pi-extensions
1
0 Fork 0
Code Issues 1 Pull Requests Packages Releases Activity

fix(tool-rendering): separate listing notices from filenames #16

Merged
eleith merged 1 commits from fix/tool-rendering-listing-notices into main 2026-11-05 18:42:00 +00:00
Conversation 0 Commits 1 Files Changed 7
+313 -38
eleith-gitea-agent Bot commented 2026-11-05 18:36:45 +00:00
Copy link
Copy source

Summary

  • Separate metadata-backed native ls/find limit and byte-truncation notices before counting, previewing, and grouping filenames.
  • Keep actionable notices visible as separate warnings, exclude them from entry/file and hidden counts, and mark byte-truncated summaries.
  • Extract notices before sanitizing the body and notice independently, so malformed terminal-control strings in filenames cannot swallow the warning.
  • Preserve limited filenames matching Pi's empty-result markers, legacy display overrides, and immutable stored/model-facing results.
  • Include a patch changeset for @eleith-pi/tool-rendering.

Validation

  • Full suite: 76 test files / 1,430 tests passed.
  • Tool-rendering suite: 195 tests passed.
  • Typecheck, lint, repository formatting, whitespace checks, and all nine extension builds passed.
  • Native public factories with pluggable operations exercise limit-only, byte-only, combined notices, oversized first lines, marker-like filenames, and unfinished OSC filenames in collapsed and expanded views.
  • Exact original SDK warning text, warning styling, placement, counts, preview bounds, and result immutability are asserted.
  • fd wording checked against installed Pi 1.5.0 source and a renderer fixture; no live fd execution, minimum-version test, or manual terminal validation performed.

Reviews

Independent code, readability, and test reviews completed. The sentinel-name and malformed-control findings were fixed with native regressions; warning assertions were strengthened to derive expectations independently from the original SDK result. All follow-up reviews are clear.

This batch is limited to ls/find notice interpretation; wrapping and output padding remain separate work.

## Summary - Separate metadata-backed native ls/find limit and byte-truncation notices before counting, previewing, and grouping filenames. - Keep actionable notices visible as separate warnings, exclude them from entry/file and hidden counts, and mark byte-truncated summaries. - Extract notices before sanitizing the body and notice independently, so malformed terminal-control strings in filenames cannot swallow the warning. - Preserve limited filenames matching Pi's empty-result markers, legacy display overrides, and immutable stored/model-facing results. - Include a patch changeset for `@eleith-pi/tool-rendering`. ## Validation - Full suite: 76 test files / 1,430 tests passed. - Tool-rendering suite: 195 tests passed. - Typecheck, lint, repository formatting, whitespace checks, and all nine extension builds passed. - Native public factories with pluggable operations exercise limit-only, byte-only, combined notices, oversized first lines, marker-like filenames, and unfinished OSC filenames in collapsed and expanded views. - Exact original SDK warning text, warning styling, placement, counts, preview bounds, and result immutability are asserted. - fd wording checked against installed Pi 1.5.0 source and a renderer fixture; no live fd execution, minimum-version test, or manual terminal validation performed. ## Reviews Independent code, readability, and test reviews completed. The sentinel-name and malformed-control findings were fixed with native regressions; warning assertions were strengthened to derive expectations independently from the original SDK result. All follow-up reviews are clear. This batch is limited to ls/find notice interpretation; wrapping and output padding remain separate work.
eleith-gitea-agent Bot added 1 commit 2026-11-05 18:36:45 +00:00
fix(tool-rendering): separate listing notices from filenames
ci/woodpecker/pr/tool-rendering Pipeline was successful
Details
ci/woodpecker/push/tool-rendering Pipeline was successful
Details
1a0c7046ac
eleith merged commit 1a0c7046ac into main 2026-11-05 18:42:00 +00:00
eleith deleted branch fix/tool-rendering-listing-notices 2026-11-05 18:42:00 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
Something is not working
 duplicate
This issue or pull request already exists
 enhancement
New feature
 help wanted
Need some help
 invalid
Something is wrong
 question
More information is needed
 wontfix
This won't be fixed
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
eleith-gitea-agent Bot eleith (eleith)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eleith/pi-extensions#16