fix(tool-rendering): prefer recorded bash execution duration #15

Merged

eleith merged 1 commits from fix/tool-rendering-recorded-duration into main 2026-11-05 16:38:57 +00:00

Conversation 0 Commits 1 Files Changed 6

+130 -23

eleith-gitea-agent Bot commented 2026-11-05 16:29:11 +00:00

Copy link

Copy source

Summary

• Prefer Pi's public recorded context.durationMs for completed and restored bash rows, including valid zero durations.
• Preserve live elapsed updates and fall back only to a genuinely observed timer when recorded metadata is unavailable.
• Start row timers only for observed running partial results, avoiding fabricated zero durations for final-only rows.
• Preserve deferred rendering, resize stability, lifecycle cleanup, and existing duration formatting.
• Add a patch changeset for @eleith-pi/tool-rendering.

Validation

• Full suite: 76 test files, 1,411 tests passed.
• Typecheck, lint, repository formatting, staged whitespace checks, and all nine extension builds passed.
• Focused duration checks: 37 tests passed, including native ToolExecutionComponent completion and restored-row metadata integration.
• No manual interactive-terminal validation performed.

Reviews

Independent code, readability, and test reviews completed with no actionable findings. New/changed duration code uses named intermediate values rather than nested function-call arguments.

This batch is limited to recorded bash duration; other Pi 1.5 alignment work remains separate.

## Summary - Prefer Pi's public recorded `context.durationMs` for completed and restored bash rows, including valid zero durations. - Preserve live elapsed updates and fall back only to a genuinely observed timer when recorded metadata is unavailable. - Start row timers only for observed running partial results, avoiding fabricated zero durations for final-only rows. - Preserve deferred rendering, resize stability, lifecycle cleanup, and existing duration formatting. - Add a patch changeset for `@eleith-pi/tool-rendering`. ## Validation - Full suite: 76 test files, 1,411 tests passed. - Typecheck, lint, repository formatting, staged whitespace checks, and all nine extension builds passed. - Focused duration checks: 37 tests passed, including native `ToolExecutionComponent` completion and restored-row metadata integration. - No manual interactive-terminal validation performed. ## Reviews Independent code, readability, and test reviews completed with no actionable findings. New/changed duration code uses named intermediate values rather than nested function-call arguments. This batch is limited to recorded bash duration; other Pi 1.5 alignment work remains separate.

eleith-gitea-agent Bot added 1 commit 2026-11-05 16:29:11 +00:00

fix(tool-rendering): prefer recorded bash execution duration d1890839e2

eleith merged commit d1890839e2 into main 2026-11-05 16:38:57 +00:00

eleith deleted branch fix/tool-rendering-recorded-duration 2026-11-05 16:38:57 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

Something is not working

duplicate

This issue or pull request already exists

enhancement

New feature

help wanted

Need some help

invalid

Something is wrong

question

More information is needed

wontfix

This won't be fixed

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

eleith-gitea-agent Bot eleith (eleith)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: eleith/pi-extensions#15