eleith/luzzle
1
1 Fork 0
Code Issues Pull Requests Packages Releases Activity

[web] focus viewer tests on meaningful regressions #192

Merged
eleith merged 1 commits from refactor/asset-viewer-tests into main 2026-11-04 19:41:57 +00:00
Conversation 0 Commits 1 Files Changed 19
+635 -3899
eleith-gitea-agent Bot commented 2026-11-04 19:28:44 +00:00
Copy link
Copy source

Summary

  • Align testing guidance with the actual reviewer philosophy: protect plausible application-owned regressions; neither test counts nor coverage percentages are goals.
  • Consolidate viewer/navigation/template and Preview/Published overview tests around distinct boundaries instead of repeating asset matrices through every parent.
  • Remove five redundant or low-value suites, cosmetic/source inventories, and misleading lifecycle tests based on independent SSR renders. Use named fixtures and setup/action/outcome scenarios instead of an HTML projection/assertion framework.
  • Preserve filename safety, generated-preview versus SDK/public asset isolation, running/completed log replay regressions, lossless source formatting, highlighting fallbacks, and meaningful renderer integration. Retain a single no-CDN Published overview case for prefix-hosted installations.
  • Include the owner's mise.toml update from Node 26.4.0 to 26.5.0.

Verification

After owner review and staging:

  • Focused surviving changed suites: 68 tests passed across 12 files.
  • Web Svelte/type check: zero errors and warnings.
  • Full web lint, documentation formatting, and staged whitespace checks passed.
  • Dedicated correctness, readability, and test reviews completed. The correctness finding about the app-base fallback without a CDN was addressed with one regression case; the owner approved it and the formatting-only follow-up before staging.

Validation is intentionally proportional: no full-workspace build/test, native HTTP, browser, container, or PageSpeed reruns for this test/docs/toolchain-only patch. Existing runtime application code, database/HTTP tests, workflow recovery tests, dependencies and deployment files are unchanged. No coverage percentage or runtime-speed improvement is claimed.

Separate follow-ups

Login alignment, a small critical-flow browser suite, and meaningful existing health data are separate PRs. These SSR tests do not claim to prove mounted lifecycle behavior, native browser routing, focus or responsive geometry.

The two owner demo archive edits are excluded.

## Summary - Align testing guidance with the actual reviewer philosophy: protect plausible application-owned regressions; neither test counts nor coverage percentages are goals. - Consolidate viewer/navigation/template and Preview/Published overview tests around distinct boundaries instead of repeating asset matrices through every parent. - Remove five redundant or low-value suites, cosmetic/source inventories, and misleading lifecycle tests based on independent SSR renders. Use named fixtures and setup/action/outcome scenarios instead of an HTML projection/assertion framework. - Preserve filename safety, generated-preview versus SDK/public asset isolation, running/completed log replay regressions, lossless source formatting, highlighting fallbacks, and meaningful renderer integration. Retain a single no-CDN Published overview case for prefix-hosted installations. - Include the owner's `mise.toml` update from Node 26.4.0 to **26.5.0**. ## Verification After owner review and staging: - Focused surviving changed suites: **68 tests passed across 12 files**. - Web Svelte/type check: **zero errors and warnings**. - Full web lint, documentation formatting, and staged whitespace checks passed. - Dedicated correctness, readability, and test reviews completed. The correctness finding about the app-base fallback without a CDN was addressed with one regression case; the owner approved it and the formatting-only follow-up before staging. Validation is intentionally proportional: no full-workspace build/test, native HTTP, browser, container, or PageSpeed reruns for this test/docs/toolchain-only patch. Existing runtime application code, database/HTTP tests, workflow recovery tests, dependencies and deployment files are unchanged. No coverage percentage or runtime-speed improvement is claimed. ## Separate follow-ups Login alignment, a small critical-flow browser suite, and meaningful existing health data are separate PRs. These SSR tests do not claim to prove mounted lifecycle behavior, native browser routing, focus or responsive geometry. The two owner demo archive edits are excluded.
eleith-gitea-agent Bot added 1 commit 2026-11-04 19:28:44 +00:00
[web] focus viewer tests on meaningful regressions
ci/woodpecker/pr/web Pipeline was successful
Details
ci/woodpecker/push/web Pipeline was successful
Details
a2e2392564
eleith merged commit a2e2392564 into main 2026-11-04 19:41:57 +00:00
eleith deleted branch refactor/asset-viewer-tests 2026-11-04 19:41:57 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
enhancement
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
eleith-gitea-agent Bot eleith (eleith)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eleith/luzzle#192