eleith/luzzle
1
1 Fork 0
Code Issues Pull Requests Packages Releases Activity

[web] prevent preview crashes from replayed progress logs #188

Merged
eleith merged 1 commits from fix/preview-progress-replay into main 2026-11-03 23:39:30 +00:00
Conversation 0 Commits 1 Files Changed 16
+293 -248
eleith-gitea-agent Bot commented 2026-11-03 23:20:59 +00:00
Copy link
Copy source

Summary

  • Start previews through an enhanced POST action, so hovering/preloading Saved cannot create jobs. Direct GETs show a confirmation form.
  • Reuse Publish's replay-safe progress merging for Preview, keeping seeded and repeated streamed log identities unique.
  • Show only the latest attempt of each phase to avoid duplicate timeline keys on retries.
  • Consolidate shared progress tests, cover both preview render paths, and include a patch changeset.

Verification

  • Manually previewed by the user without a 500.
  • 2,123 web tests and 61 native production HTTP tests pass.
  • Web type check, lint, build, and whitespace checks pass; 15 existing Svelte initialization warnings remain.
  • Correctness/readability and test reviews have no remaining actionable findings.

Forced browser EventSource replay remains unverified; helper replay and running/completed SSR cases are covered. No browser infrastructure was added.

## Summary - Start previews through an enhanced POST action, so hovering/preloading Saved cannot create jobs. Direct GETs show a confirmation form. - Reuse Publish's replay-safe progress merging for Preview, keeping seeded and repeated streamed log identities unique. - Show only the latest attempt of each phase to avoid duplicate timeline keys on retries. - Consolidate shared progress tests, cover both preview render paths, and include a patch changeset. ## Verification - Manually previewed by the user without a 500. - 2,123 web tests and 61 native production HTTP tests pass. - Web type check, lint, build, and whitespace checks pass; 15 existing Svelte initialization warnings remain. - Correctness/readability and test reviews have no remaining actionable findings. Forced browser EventSource replay remains unverified; helper replay and running/completed SSR cases are covered. No browser infrastructure was added.
eleith-gitea-agent Bot added 1 commit 2026-11-03 23:20:59 +00:00
[web] make previews explicit and progress replay-safe
ci/woodpecker/pr/web Pipeline was successful
Details
ci/woodpecker/push/web Pipeline was successful
Details
a9151cce9a
eleith merged commit a9151cce9a into main 2026-11-03 23:39:30 +00:00
eleith deleted branch fix/preview-progress-replay 2026-11-03 23:39:30 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
bug
enhancement
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
eleith-gitea-agent Bot eleith (eleith)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eleith/luzzle#188