[web] fix Preview job switching and attachment downloads #119

Merged

eleith merged 2 commits from fix/116-117-preview-lifecycle-attachments into main 2026-10-17 01:01:07 +00:00

Conversation 0 Commits 2 Files Changed 8

+299 -43

eleith-gitea-agent Bot commented 2026-10-17 00:39:59 +00:00

Copy link

Copy source

Summary

Closes #116. Closes #117.

Two focused commits on one branch:

1. Reset Preview state when switching jobs (1ccb6d72)

Key the Preview reset layout's child subtree by params.jobId. Switching jobs now remounts the stateful job layout, initializing that job's status, links, errors, phases and logs and closing the previous progress stream. The same job keeps its state and observer across Overview/Page/Icon/Share tabs.

The key uses the unique job ID directly, as agreed in code review; no serialized file/job pair or additional lifecycle framework.

2. Copy attachments into Preview job outputs (9e5e21bc)

Include the existing attachment transform in Preview's transform list. The workflow already supplies every transform with the isolated job output directory, so the existing copying code now writes attachments alongside that job's images and Open Graph PNG:

<dirname(config.paths.assets)>/previews/<jobId>/<type>/<pieceKey>/<filename>

Remove fabricated archive-path attachment passthroughs from Preview assembly. Download helpers now receive actual worker-generated attachment records; old retained jobs without attachment outputs no longer offer fabricated download links. Image fallbacks and output-only Overview inspection are preserved.

No new dependencies, services, archive writes, CDN uploads, serving-path exceptions, or publish behavior changes. No README changes. Each fix has its own patch changeset.

Verification

• Full web suite: 72 files / 1,276 tests passed.
• Full worker suite: 46 files / 279 tests passed, with coverage; Preview transform step has 100% coverage.
• Web production build and worker production TypeScript build: passed.
• Svelte check: 0 errors / 0 warnings.
• Changed-file web lint/formatting, worker lint, and git diff --check: passed.
• A temporary headless-browser fixture using the actual client layout components reproduced stale links/logs/stream before the fix and verified keyed-subtree replacement, same-job tab preservation, stream cleanup, and terminal-state behavior. No real Preview workflows were started. The committed lifecycle regression is explicitly a structural/SSR guard, not a browser navigation test.
• Attachment workflow tests use the production transform list, real attachment copying, temporary files, and SQLite. They verify generated records, job-local bytes, phase reporting, and absence of reported outputs when copying fails. Assembly/helper tests verify actual download URLs and removal of fabricated references.

Retention and existing limitations

Attachments share the existing job directory cleanup: recursive deletion during the normal purge (startup and daily, 7-day retention). The UI's existing 2-day expiry is unchanged. Retained previews need regeneration to acquire attachments.

The existing attachment output naming can collide for files with identical basenames; this already affects publishing and is not changed here.

Existing local demo archive edits and generated preview artifacts are excluded from both commits.

## Summary Closes #116. Closes #117. Two focused commits on one branch: ### 1. Reset Preview state when switching jobs (`1ccb6d72`) Key the Preview reset layout's child subtree by `params.jobId`. Switching jobs now remounts the stateful job layout, initializing that job's status, links, errors, phases and logs and closing the previous progress stream. The same job keeps its state and observer across Overview/Page/Icon/Share tabs. The key uses the unique job ID directly, as agreed in code review; no serialized file/job pair or additional lifecycle framework. ### 2. Copy attachments into Preview job outputs (`9e5e21bc`) Include the existing `attachment` transform in Preview's transform list. The workflow already supplies every transform with the isolated job output directory, so the existing copying code now writes attachments alongside that job's images and Open Graph PNG: ```text <dirname(config.paths.assets)>/previews/<jobId>/<type>/<pieceKey>/<filename> ``` Remove fabricated archive-path attachment passthroughs from Preview assembly. Download helpers now receive actual worker-generated attachment records; old retained jobs without attachment outputs no longer offer fabricated download links. Image fallbacks and output-only Overview inspection are preserved. No new dependencies, services, archive writes, CDN uploads, serving-path exceptions, or publish behavior changes. No README changes. Each fix has its own patch changeset. ## Verification - Full web suite: **72 files / 1,276 tests passed**. - Full worker suite: **46 files / 279 tests passed**, with coverage; Preview transform step has 100% coverage. - Web production build and worker production TypeScript build: passed. - Svelte check: **0 errors / 0 warnings**. - Changed-file web lint/formatting, worker lint, and `git diff --check`: passed. - A temporary headless-browser fixture using the actual client layout components reproduced stale links/logs/stream before the fix and verified keyed-subtree replacement, same-job tab preservation, stream cleanup, and terminal-state behavior. No real Preview workflows were started. The committed lifecycle regression is explicitly a structural/SSR guard, not a browser navigation test. - Attachment workflow tests use the production transform list, real attachment copying, temporary files, and SQLite. They verify generated records, job-local bytes, phase reporting, and absence of reported outputs when copying fails. Assembly/helper tests verify actual download URLs and removal of fabricated references. ## Retention and existing limitations Attachments share the existing job directory cleanup: recursive deletion during the normal purge (startup and daily, 7-day retention). The UI's existing 2-day expiry is unchanged. Retained previews need regeneration to acquire attachments. The existing attachment output naming can collide for files with identical basenames; this already affects publishing and is not changed here. Existing local demo archive edits and generated preview artifacts are excluded from both commits.

eleith-gitea-agent Bot added 2 commits 2026-10-17 00:40:00 +00:00

[web] reset Preview state when switching jobs 1ccb6d7276

[web.worker] copy attachments into Preview job outputs 9e5e21bce3

eleith merged commit 9e5e21bce3 into main 2026-10-17 01:01:07 +00:00

eleith deleted branch fix/116-117-preview-lifecycle-attachments 2026-10-17 01:01:07 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

bug

enhancement

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

eleith-gitea-agent Bot eleith (eleith)

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: eleith/luzzle#119