Clarify Porkbun credential and API errors #3

Merged

eleith merged 2 commits from fix-porkbun-ddns-credential-errors into main 2026-10-24 14:04:09 +00:00

Conversation 0 Commits 2 Files Changed 5

+349 -75

eleith-gitea-agent Bot commented 2026-10-24 04:45:30 +00:00

Copy link

Copy source

Summary

• Distinguish missing/mis-mounted or unreadable credentials files from invalid JSON, missing fields, and whitespace in keys.
• Report rejected API credentials separately from API-access denials, network failures, HTTP errors, and malformed responses without logging secrets or raw responses.
• Keep response names and diagnostic wording precise, simplify credential-error classification, and leave unclassified API errors neutral.
• Expand mocked tests and add concise troubleshooting guidance; correct the example image version.

Validation

• All 30 mocked-HTTP tests pass.
• ShellCheck, Bash syntax checks, and whitespace checks pass.
• Live --dry-run succeeded and reported the existing A record unchanged; no DNS changes made.
• Docker builds and runs remain user-managed and were not performed.

## Summary - Distinguish missing/mis-mounted or unreadable credentials files from invalid JSON, missing fields, and whitespace in keys. - Report rejected API credentials separately from API-access denials, network failures, HTTP errors, and malformed responses without logging secrets or raw responses. - Keep response names and diagnostic wording precise, simplify credential-error classification, and leave unclassified API errors neutral. - Expand mocked tests and add concise troubleshooting guidance; correct the example image version. ## Validation - All 30 mocked-HTTP tests pass. - ShellCheck, Bash syntax checks, and whitespace checks pass. - Live `--dry-run` succeeded and reported the existing A record unchanged; no DNS changes made. - Docker builds and runs remain user-managed and were not performed.

eleith added 1 commit 2026-10-24 13:57:23 +00:00

Clarify Porkbun credential and API errors e5bddc9e94

eleith force-pushed fix-porkbun-ddns-credential-errors from b5906bec8c to e5bddc9e94 2026-10-24 13:57:23 +00:00 Compare

eleith added 1 commit 2026-10-24 14:03:54 +00:00

run tests on prs 12a2574642

eleith merged commit 12a2574642 into main 2026-10-24 14:04:09 +00:00

eleith deleted branch fix-porkbun-ddns-credential-errors 2026-10-24 14:04:09 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

No items

No labels

Milestone

No items

No Milestone

Assignees

Clear assignees

eleith-gitea-agent Bot eleith (eleith)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: eleith/containers#3