eleith/when
1
1 Fork 0
Code Issues Pull Requests Packages Releases Activity

fix(web): match duration picker accessible and visible labels #119

Merged
eleith merged 1 commits from fix/duration-picker-accessible-name into main 2026-11-02 23:04:59 +00:00
Conversation 0 Commits 1 Files Changed 3
+9 -4
eleith-gitea-agent Bot commented 2026-11-02 23:03:34 +00:00
Copy link
Copy source

Summary

Fix the PageSpeed accessibility finding that the duration button's accessible name does not match its visible label.

  • Change the accessible name from “Change duration, currently 30 minutes” to “30 min, change duration”, retaining the selected duration dynamically.
  • Keep the visible label and booking behavior unchanged.
  • Update duration E2E selectors and check visible text before and after changing duration.
  • Include a patch changeset for @when/web.

This addresses accessibility only; no performance-score improvement is claimed. Fonts, CSS, avatar, and timezone work remain separate.

Validation

  • All 12 Chromium tests in e2e/host-durations.e2e.ts passed.
  • Svelte check: 0 errors and 0 warnings.
  • Prettier checks passed for both modified files and the changeset.
  • git diff --check passed.
## Summary Fix the PageSpeed accessibility finding that the duration button's accessible name does not match its visible label. - Change the accessible name from “Change duration, currently 30 minutes” to “30 min, change duration”, retaining the selected duration dynamically. - Keep the visible label and booking behavior unchanged. - Update duration E2E selectors and check visible text before and after changing duration. - Include a patch changeset for `@when/web`. This addresses accessibility only; no performance-score improvement is claimed. Fonts, CSS, avatar, and timezone work remain separate. ## Validation - All 12 Chromium tests in `e2e/host-durations.e2e.ts` passed. - Svelte check: 0 errors and 0 warnings. - Prettier checks passed for both modified files and the changeset. - `git diff --check` passed.
eleith-gitea-agent Bot added 1 commit 2026-11-02 23:03:34 +00:00
fix(web): match duration picker accessible and visible labels
ci/woodpecker/pr/web Pipeline was successful
Details
ci/woodpecker/push/web Pipeline was successful
Details
aaf9eea42f
eleith merged commit aaf9eea42f into main 2026-11-02 23:04:59 +00:00
eleith deleted branch fix/duration-picker-accessible-name 2026-11-02 23:04:59 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
blocked
Waiting on a prerequisite before work can proceed
 bug
Something is not working
 enhancement
New feature
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
eleith-gitea-agent Bot eleith (eleith)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: eleith/when#119