tsc: compat with v3.8.3

This commit is contained in:
Zack Schuster 2022-04-13 09:35:51 -07:00
parent 54e03335bf
commit f064ff1302
6 changed files with 25 additions and 11 deletions

View File

@ -9,6 +9,12 @@
"plugin:@typescript-eslint/recommended"
],
"rules": {
"@typescript-eslint/ban-ts-comment": [
"error",
{
"ts-ignore": "allow-with-description"
}
],
"@typescript-eslint/no-explicit-any": [
"error",
{

View File

@ -33,7 +33,15 @@
"smtp-server": "3.10.0",
"ts-node": "10.7.0",
"tslib": "2.3.1",
"typescript": "4.6.2"
"typescript": "3.8.3"
},
"peerDependencies": {
"typescript": ">=3.8.3"
},
"peerDependenciesMeta": {
"typescript": {
"optional": true
}
},
"resolutions": {
"nodemailer": "6.7.2"

View File

@ -47,9 +47,9 @@ export class SMTPClient {
* @param {MessageCallback} callback .
* @returns {void}
*/
public send<T extends Message | MessageHeaders>(
msg: T,
callback: MessageCallback<T>
public send(
msg: Message | MessageHeaders,
callback: MessageCallback<Message | MessageHeaders>
) {
const message =
msg instanceof Message

View File

@ -87,7 +87,7 @@ test('client invokes callback exactly once for invalid connection', async (t) =>
incrementCounter();
}
});
// @ts-expect-error the error event is only accessible from the protected socket property
// @ts-ignore the error event is only accessible from the protected socket property
invalidClient.smtp.sock.once('error', () => {
if (counter === 1) {
resolve();
@ -349,7 +349,7 @@ test('client send can have result awaited when promisified', async (t) => {
};
try {
const message = await sendAsync(new Message(msg));
const message = (await sendAsync(new Message(msg))) as Message;
t.true(message instanceof Message);
t.like(message, {
alternative: null,

View File

@ -10,7 +10,7 @@ import { MessageHeaders } from '../smtp/message';
// eslint-disable-next-line no-var
var __dirname: string;
// @ts-expect-error compat hack for node 10
// @ts-ignore compat hack for node 10
if (__dirname == null) {
__dirname = join(process.cwd(), 'test');
}

View File

@ -2682,10 +2682,10 @@ typedarray-to-buffer@^3.1.5:
dependencies:
is-typedarray "^1.0.0"
typescript@4.6.2:
version "4.6.2"
resolved "https://registry.npmjs.org/typescript/-/typescript-4.6.2.tgz#fe12d2727b708f4eef40f51598b3398baa9611d4"
integrity sha512-HM/hFigTBHZhLXshn9sN37H085+hQGeJHJ/X7LpBWLID/fbc2acUMfU+lGD98X81sKP+pFa9f0DZmCwB9GnbAg==
typescript@3.8.3:
version "3.8.3"
resolved "https://registry.npmjs.org/typescript/-/typescript-3.8.3.tgz#409eb8544ea0335711205869ec458ab109ee1061"
integrity sha512-MYlEfn5VrLNsgudQTVJeNaQFUAI7DkhnOjdpAp4T+ku1TfQClewlbSuTVHiA+8skNBgaf02TL/kLOvig4y3G8w==
uc.micro@^1.0.1:
version "1.0.6"