eleith/emailjs
1
0
Fork 0
mirror of https://github.com/eleith/emailjs.git synced 2024-07-05 20:10:37 +00:00
Code Issues Projects Releases Wiki Activity

force close smtp on auth failure, so all callbacks get called

Browse Source
This commit is contained in:
eleith 2014-07-05 17:01:42 -07:00
parent 8fdcab32d8
commit 89267deb7a
2 changed files with 15 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
smtp/client.js
View File

@ -50,8 +50,13 @@ Client.prototype =
self.ready = true;
self._poll();
}
else
else {
stack.callback(err, stack.message);
// clear out the queue so all callbacks can be called with the same error message
self.queue.shift();
self._poll();
}
};
if(!self.smtp.authorized())
@ -60,8 +65,13 @@ Client.prototype =
else
self.smtp.ehlo_or_helo_if_needed(begin);
}
else
else {
stack.callback(err, stack.message);
// clear out the queue so all callbacks can be called with the same error message
self.queue.shift();
self._poll();
}
};
self.ready = false;
@ -86,9 +96,9 @@ Client.prototype =
{
var stack =
{
message: msg,
message: msg,
to: address.parse(msg.header.to),
from: address.parse(msg.header.from)[0].address,
from: address.parse(msg.header.from)[0].address,
callback: callback || function() {}
};

1
smtp/smtp.js
View File

@ -439,6 +439,7 @@ SMTP.prototype = {
// handle bad responses from command differently
var failed = function(err, data) {
self.loggedin = false;
self.close(); // if auth is bad, close the connection, it won't get better by itself
caller(callback, SMTPError('authorization.failed', SMTPError.AUTHFAILED, err, data));
};