From 2e6d32a403fcc3a1b8237bb8952c32ece52e3db0 Mon Sep 17 00:00:00 2001 From: Zack Schuster Date: Fri, 6 Jul 2018 11:26:17 -0700 Subject: [PATCH] extract canMakeMessage to private method --- smtp/client.js | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/smtp/client.js b/smtp/client.js index 9b8e9d1..ebdae9e 100644 --- a/smtp/client.js +++ b/smtp/client.js @@ -127,23 +127,15 @@ class Client { * @returns {void} */ send(msg, callback) { - /** - * @param {MessageStack} m message stack - * @returns {boolean} can make message - */ - const canMakeMessage = m => { - return ( - m.from && - (m.to || m.cc || m.bcc) && - (m.text !== undefined || this._containsInlinedHtml(m.attachment)) - ); - }; - /** * @type {Message} */ const message = - msg instanceof Message ? msg : canMakeMessage(msg) ? create(msg) : null; + msg instanceof Message + ? msg + : this._canMakeMessage(msg) + ? create(msg) + : null; if (message == null) { callback( @@ -187,6 +179,18 @@ class Client { }); } + /** + * @param {MessageStack} msg message stack + * @returns {boolean} can make message + */ + _canMakeMessage(msg) { + return ( + msg.from && + (msg.to || msg.cc || msg.bcc) && + (msg.text !== undefined || this._containsInlinedHtml(msg.attachment)) + ); + } + /** * @param {*} attachment attachment * @returns {boolean} does contain